Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on sys.version_info (w/o class=src_hover) crashes server #33

Open
kamahen opened this issue Dec 20, 2020 · 0 comments
Open

Click on sys.version_info (w/o class=src_hover) crashes server #33

kamahen opened this issue Dec 20, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@kamahen
Copy link
Owner

kamahen commented Dec 20, 2020

There are two problems here:

  1. If a token without "src_hover" is clicked, then the xref request fails (because there's no kythe_node fact for that token.

  2. Some instances of sys.version_info aren't being processed properly (but not all).

Example (needs to be made shorter):
http://localhost:9999/static/src_browser.html?corpus=CORPUS&root=CORPUS&path=tmp/pykythe_test/SUBST/BUILTINS/builtins.pyi#L1918
(and in other parts of the file, including near the beginning)

@kamahen kamahen added the bug Something isn't working label Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant