Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: class_from_attr and output_kythe #38

Open
kamahen opened this issue Feb 24, 2021 · 0 comments
Open

Performance: class_from_attr and output_kythe #38

kamahen opened this issue Feb 24, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@kamahen
Copy link
Owner

kamahen commented Feb 24, 2021

Profiling shows output_kythe/7 at 30% and assign_exprs/6 at 52%.
For assign_exprs/6, almost all seems to be in possible_classes_from_attr/5, which ends up spending almost all of its time in conv_symtab_pairs/3.
The cost seems to be in scanning the entire symtab, so probably should have an inverted list for class attributes.

  • BUT: this probably only applies to sources that have lots of unresolved attributes, so better to first resolve as many attrs as possible.

As for output_kythe - see Issue #5.

@kamahen kamahen added the enhancement New feature or request label Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant