Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change etcd liveness probes to the new livez and readyz endpoints #5419

Open
4 tasks
liangyuanpeng opened this issue Aug 24, 2024 · 2 comments
Open
4 tasks
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Aug 24, 2024

What would you like to be added:

Using the /livez for LivenessProbe and /readyz for StartupProbe, this is This works for etcd >= v3.5.11, kubeadm has already applied this change, I think the same can be applied on karmada side.

basicly /livez = /health?exclude=NOSPACE&serializable=true and /readyz=/health?serializable=false

The design for the new probes is documented in etcd livez and readyz probes

releated:

Tasks:

  • CI
  • karmadactl
  • helm
  • operator

Why is this needed:

This is more in line with the kubernetes style.

@liangyuanpeng liangyuanpeng added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 24, 2024
@zhzhuang-zju
Copy link
Contributor

Can other components of Karmada make the same modifications?

@liangyuanpeng
Copy link
Contributor Author

Can other components of Karmada make the same modifications?

Absolutely!

This makes sense for all components, but given that we recently completed the specification of metrics and health detection port parameters #5219, I don't think livez and readyz standardization for karmada components will happen too soon, at least not until version 1.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: No status
Development

No branches or pull requests

2 participants