-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart testing enhancement #5436
Comments
May be #4045 addresses part of this. |
here is another shortage I want to raise:
just like: I firstly execute then all karmada certs is stored in karmada/charts/karmada/templates/pre-install-job.yaml Lines 249 to 253 in 295dee8
Then I execute the estimator needs to mount that karmada/charts/karmada/templates/_helpers.tpl Lines 352 to 356 in 295dee8
Actually, karmada/charts/karmada/values.yaml Lines 969 to 972 in 295dee8
that is, redeclare the secret name in but I think the best way is fix the secret name, don't prefix it with |
What would you like to be added:
Why is this needed:
Currently, helm testing does not test against the latest code but the last images on image registry. When we introduce new parameters to a component the chart test will fail due to unrecognized parameters, see the example here: #5290 (comment).
In addition, the helm chart test coverage is not enough, it just tests part of the components, for example, the
karmada-scheduler-estimator
is not included in the test, that's why it passes #5273.The text was updated successfully, but these errors were encountered: