Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: CADAiD backend integration #74

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Feat: CADAiD backend integration #74

merged 6 commits into from
Nov 6, 2024

Conversation

andreaslhjulstad
Copy link
Collaborator

No description provided.

@andreaslhjulstad
build: fix webapp port CORS error
2a83b1e 
CADAiD only allows requests from 3000 and 5000
@andreaslhjulstad
build: fix database not running in docker
0a84c13 
since docker is a debian image, we need debian openssl to run the database
@andreaslhjulstad
feat: integrate CADAiD page with backend
c916b27 
Now stores responses and creates applications if they don't already exist
@andreaslhjulstad andreaslhjulstad linked an issue Nov 5, 2024 that may be closed by this pull request
CADAiD backend integration #72
Open
@andreaslhjulstad andreaslhjulstad changed the title Feat/72 cadaid backend integration Feat: CADAiD backend integration Nov 5, 2024
@andreaslhjulstad andreaslhjulstad self-assigned this Nov 5, 2024
SverreNystad
SverreNystad approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@SverreNystad SverreNystad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the port of 3000 is needed for CORS for ArkivGPT then all else is good

docker-compose.yml Show resolved Hide resolved
johanneeo
johanneeo reviewed Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@johanneeo johanneeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Magnus is updating the README so it's easier to run

@andreaslhjulstad
merge: fix merge conflict
8a2b5e6 
Also fixed some layout issues
@andreaslhjulstad andreaslhjulstad merged commit 462bf9e into main Nov 6, 2024
1 check passed
@andreaslhjulstad andreaslhjulstad deleted the feat/72-cadaid-backend-integration branch November 7, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanneeo johanneeo johanneeo left review comments

@SverreNystad SverreNystad SverreNystad approved these changes

Assignees

@andreaslhjulstad andreaslhjulstad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CADAiD backend integration
3 participants
@andreaslhjulstad @johanneeo @SverreNystad