Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller popper popup height first time #34

Open
anildigital opened this issue Apr 5, 2022 · 5 comments
Open

Smaller popper popup height first time #34

anildigital opened this issue Apr 5, 2022 · 5 comments

Comments

@anildigital
Copy link

When I run vterm, I notice it opens a small popup, but height is less. But when buffer has more text and I toggle popper-toggle-latest a different height is applied. I expect popper popup window to have consistent height.

When I open normally
image

When I run something in vterm and it logs more text into the buffer and I toggle popper-toggle-latest, it shows a different height

image

What I expect is the height to stay consistent as in second screenshot, the height in first screenshot is too small to work into.

@karthink
Copy link
Owner

karthink commented Apr 6, 2022 via email

@anildigital
Copy link
Author

@karthink here it is

(use-package
  popper
  :ensure t
  :bind (("C-`"   . popper-toggle-latest)
         ("M-`"   . popper-cycle)
         ("C-M-`" . popper-toggle-type))
  :hook ((popper-open-popup-hook . centaur-tabs-local-mode))
  :init
  (setq popper-reference-buffers '("eshell*"
                                   "shell*"
                                   "vterm"
                                   "*SQL"
                                   "*exunit-compilation*"
                                   help-mode
                                   compilation-mode))
  (popper-mode +1)
  (popper-echo-mode +1))

@1player
Copy link

1player commented Apr 28, 2022

Same here with a similar configuration. Whatever the frame size, the compilation-mode popup started with recompile is always 5 lines high. If I toggle with popper-toggle-latest, it shows it in its correct size.

@NikhilRajPandey
Copy link

Try add (setq popper-window-height 15) for consistent height of popper

@karthink
Copy link
Owner

karthink commented Jul 9, 2022

I haven't had the time to track down this bug. For now, I second @NikhilRajPandey's workaround. You can also set popper-window-height to a fraction of the frame height. For example:

(setq popper-window-height 0.33)

will fix popup height at 33% of the frame size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants