Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MacOS release binary to Darwin #317

Open
cf-sewe opened this issue Dec 6, 2024 · 0 comments
Open

Rename MacOS release binary to Darwin #317

cf-sewe opened this issue Dec 6, 2024 · 0 comments

Comments

@cf-sewe
Copy link

cf-sewe commented Dec 6, 2024

Issue Description

The release assets for Kubestr version 0.4.47 label the macOS binaries as MacOS (e.g., kubestr_0.4.47_MacOS_amd64.tar.gz). However, in Unix-like systems, including macOS, the operating system is identified as Darwin. For example, running uname on a macOS terminal returns:

$ uname
Darwin

Additionally, configuration management tools like Ansible recognize the system as Darwin. For instance, the ansible_system fact on macOS is:

"ansible_system": "Darwin"

Motivation

Using MacOS in the release asset filenames introduces challenges in automation workflows. Automation tools, such as Ansible, rely on system identifiers like ansible_system or ansible_os_family, which return Darwin for macOS systems. This discrepancy necessitates additional conditional handling in automation scripts to map Darwin to MacOS, complicating the automation process. For example, an Ansible playbook might need to include conditional statements to handle this mismatch:

- name: Set platform-specific variables
  set_fact:
    kubestr_filename: >
      {% if ansible_system == 'Darwin' %}
        kubestr_0.4.47_MacOS_amd64.tar.gz
      {% elif ansible_system == 'Linux' %}
        kubestr_0.4.47_Linux_amd64.tar.gz
      {% endif %}

This added complexity can be avoided by aligning the release asset naming with standard system identifiers.

Proposed Change

To enhance consistency and simplify automation processes, it is recommended to rename the macOS release assets using Darwin instead of MacOS. For example:

  • kubestr_0.4.47_Darwin_amd64.tar.gz
  • kubestr_0.4.47_Darwin_arm64.tar.gz

This change would align the release asset names with standard system identifiers, facilitating more straightforward automation and integration.

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant