Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esque edit & apply doesn't apply changes to partitions and replication #28

Closed
MrTrustworthy opened this issue Jul 7, 2019 · 5 comments
Closed

esque edit & apply doesn't apply changes to partitions and replication #28

MrTrustworthy opened this issue Jul 7, 2019 · 5 comments
Assignees
@MrTrustworthy
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@MrTrustworthy
Copy link
Contributor

No description provided.

@swenzel
Copy link
Contributor

swenzel commented Jul 19, 2019

The replication thing is a little more complicated. Not even "official" topic edit command line tool can do this. You'll have to start a partition reassignment, where every partition gets assigned to the desired number of brokers. Meaning that you'll have to consider balancing if you don't want to assign/remove them randomly.

@MrTrustworthy
Copy link
Contributor Author

Well that sucks. The least we can do for now is failing loudly if the user attempts to change those settings then

@MrTrustworthy MrTrustworthy mentioned this issue Aug 18, 2019
Merged
@MrTrustworthy MrTrustworthy added the bug Something isn't working label Aug 18, 2019
@MrTrustworthy MrTrustworthy self-assigned this Aug 18, 2019
@MrTrustworthy MrTrustworthy added this to the 1.0.0 milestone Aug 18, 2019
@MrTrustworthy
Copy link
Contributor Author

This issue also applies to esque apply

@MrTrustworthy MrTrustworthy changed the title esque edit doesn't apply changes to partitions and replication esque edit & apply doesn't apply changes to partitions and replication Aug 18, 2019
@MrTrustworthy MrTrustworthy added enhancement New feature or request and removed bug Something isn't working labels Aug 18, 2019
@MrTrustworthy
Copy link
Contributor Author

With #27 esque edit will no longer show the non-editable properties and esque apply will warn that it won't change those settings on existing topics. Removing the "bug" label and adding "enhancement"

@MrTrustworthy
Copy link
Contributor Author

Closing in favour of #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrTrustworthy MrTrustworthy

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@swenzel @MrTrustworthy