You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Cluster default retention is 100ms
Create topic with retention of 50ms (ex. via esque apply)
Specify no retention for this topic in a config
Change the topic based on the config with esque apply
Expected: esque apply shows the change as "50ms -> 100ms" and applies this correctly when confirming
Actual: esque apply doesn't show the change. Not sure if it's applied correctly.
Notes:
This relates to the fact that we ignore None values for the new changes in AttributeDiffs. Instead, we should treat None values as ClusterDefault for this setting.
If we simply show the None, we'd get a diff for EVERYTHING that we haven't specified.
To solve, we need to do the following in the case that the new value is None: IF old_val IS NOT cluster_default THEN show change as old_val -> cluster_default and IF old_val IS cluster_default THEN show no change.
Open questions:
How do we get the cluster defaults?
What happens if we submit a None setting to the client when we change a topic? Will it revert to the cluster default? I'd assume yes, but this should also be tested (ideally as part of the test suite, I don't trust any of the clients to not have regressions on this at some point).
The text was updated successfully, but these errors were encountered:
Additional note: If it turns out that submitting a value of None for a configuration property causes the property to be automatically set to cluster default, we don't necessarily need to know the cluster defaults. Instead, we could store all changes in a topic as mentioned in #22 and use that info to decide whether we need to change something.
Example case:
Expected:
esque apply
shows the change as "50ms -> 100ms" and applies this correctly when confirmingActual:
esque apply
doesn't show the change. Not sure if it's applied correctly.Notes:
This relates to the fact that we ignore
None
values for the new changes in AttributeDiffs. Instead, we should treatNone
values asClusterDefault for this setting
.If we simply show the
None
, we'd get a diff for EVERYTHING that we haven't specified.To solve, we need to do the following in the case that the new value is None:
IF old_val IS NOT cluster_default THEN show change as old_val -> cluster_default
andIF old_val IS cluster_default THEN show no change
.Open questions:
How do we get the cluster defaults?
What happens if we submit a
None
setting to the client when we change a topic? Will it revert to the cluster default? I'd assume yes, but this should also be tested (ideally as part of the test suite, I don't trust any of the clients to not have regressions on this at some point).The text was updated successfully, but these errors were encountered: