Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please leave logging a user's choice #18

Open
mmben opened this issue May 27, 2021 · 0 comments · May be fixed by #36
Open

Please leave logging a user's choice #18

mmben opened this issue May 27, 2021 · 0 comments · May be fixed by #36

Comments

@mmben
Copy link

mmben commented May 27, 2021

Hi,
I just updated my application from 1.0.6 to 1.0.7 and then back down again, because of the console logs that have been added in PR #15 .

We faced the same desire to be able to log what has actually been migrated. Since this package lacks the possibility we simply made a diff of the migrations table before and after running it and logged it.

Version 1.0.7 seem to even log the migrations SQL-Statements which clutters up our output.
I know no other library that logs to console just like that.
I also think from a security point of view, this is not a good idea at all, because I don't want to expose database internals via the console output.

Please add a possibility to opt-out of these console logs or reconsider them.
We would welcome a better possibility to log what migration has been executed, but rather by API than by console log.

@lewismoten lewismoten linked a pull request Jun 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant