Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document development dependency on yarn #42

Open
mmurphy opened this issue Nov 1, 2018 · 0 comments
Open

Document development dependency on yarn #42

mmurphy opened this issue Nov 1, 2018 · 0 comments

Comments

@mmurphy
Copy link

mmurphy commented Nov 1, 2018

Since this repo includes a yarn.lock file and git hooks, any commits will require the yarn command.
Otherwise it will generate an error:

mmurphy-OSX:git-pre-commit mmurphy$ git commit
events.js:167
      throw er; // Unhandled 'error' event
      ^

Error: spawn yarn ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:232:19)
    at onErrorNT (internal/child_process.js:407:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)
    at Function.Module.runMain (internal/modules/cjs/loader.js:744:11)
    at startup (internal/bootstrap/node.js:285:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:739:3)
Emitted 'error' event at:
    at Process.ChildProcess._handle.onexit (internal/child_process.js:238:12)
    at onErrorNT (internal/child_process.js:407:16)
    [... lines matching original stack trace ...]
    at bootstrapNodeJSCore (internal/bootstrap/node.js:739:3)

Should the dependency on yarn be documented in the README or a contributing file? Or give a better error from pre-commit-utils/package-manager-utils.js if yarn is not installed?

WDYT?

felquis added a commit to felquis/git-pre-commit that referenced this issue Jun 3, 2020
closes kazazor#43 I did this PR working with nodejs 14.x
closes kazazor#42 since there's no dependency on yarn
closes kazazor#41 package-lock.json should always be commited
closes kazazor#40 require-dir is not a dependency on this source

About kazazor#3 this PR was tested on PowerShell on Windows 10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant