Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version string for "Download ZIP" #4

Open
furutaka opened this issue Nov 4, 2015 · 2 comments
Open

Version string for "Download ZIP" #4

furutaka opened this issue Nov 4, 2015 · 2 comments

Comments

@furutaka
Copy link
Collaborator

furutaka commented Nov 4, 2015

I made the version string taken from the output of git describe --tags --long. It's OK if the tools were downloaded by doing git clone, but when the source was downloaded as a ZIP the version string becomes 0.0.0.
I think we need to add a GitHub hook to set the version string in setup.py for ZIP downloads, thought I know almost nothing about the hooks. (A negative/tempral solution would be to disable "Download ZIP")

@kbat
Copy link
Owner

kbat commented Nov 4, 2015

Why can't we just set up version manually? From my point of view, changing version is not something we do every day, therefore I think it's OK to do it manually when we decide to do it.
As far as I know, even in such a large project like Plone they recommend to do it manually, llike, for instance, in this setup.py.

@furutaka
Copy link
Collaborator Author

furutaka commented Nov 4, 2015

I think it's OK to manually set the version number if you release only some selected/tagged commits as tarballs/zips. But cloned source files from an open repository differ for every commit, and therefore I think it's better to assign every commit a version tag for identification. I also tend to forget rewriting the version number for some files... ;-<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants