Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-numeric serial number #213

Open
MagiX13 opened this issue Nov 24, 2024 · 3 comments
Open

Non-numeric serial number #213

MagiX13 opened this issue Nov 24, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@MagiX13
Copy link

MagiX13 commented Nov 24, 2024

For some reason, my Deye SUN-M80G3-EU-Q0 (obtained in Nov 2023, never upgrade the firmware thus running MW3_16U_5406_2.27) has a non-numeric serial number, ending with BD.

I made some local changes to accommodate this, but was wondering if there are more people with this/there is a need for a pull request - I think it amounts to 3-4 lines that I had to change. I had it running with these changes since March already and it seems stable. Today I decided to update the docker repo and saw that this is still not supported and would be happy to submit a PR.

@MagiX13 MagiX13 added the enhancement New feature or request label Nov 24, 2024
@kbialek
Copy link
Owner

kbialek commented Nov 25, 2024

hi! I think it was a bad design decision to model the serial number as integer, so if you would like to submit a PR fixing this, that would be great.

Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Dec 26, 2024
@thalesmaoa
Copy link

Same problem here. Serial number ending with F character. @MagiX13 , I'm sorry, but I wasn't able to find your fork. Can you provide the places you've edited?
I just got a SUN-M225G4.

@github-actions github-actions bot removed the stale label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants