Redundancy in rule for strings?

[jlkiri]

Won't this be sufficient?

- string := '"' ('\\' ["\\] | [^"])* '"'
+ string := '"' ('\\' ["] | [^"])* '"'

Nearly version for testing: string -> "\"" ("\\" [\"] | [^"]):* "\""

[jlkiri]

Apparently the grammar changed a bit while I was writing this. Should be OK.

[zkat]

haha yeah I literally just finished writing the actual parser and updated the grammar in the process. I'm working on tests now and will push it shortly 👍🏻

[zkat]

The string grammar has been fixed and expanded so this should be done :)

[larsgw]

The reason I put it in like that is to be able to escape backslashes at the end of the string. Otherwise "foo\\" would not end the string, though backtracking may circumvent the problem entirely.