Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate invalid tests in filename? #365

Open
tabatkins opened this issue Dec 26, 2023 · 1 comment
Open

Indicate invalid tests in filename? #365

tabatkins opened this issue Dec 26, 2023 · 1 comment

Comments

@tabatkins
Copy link
Contributor

Currently, if you're reviewing the test suite and want to know if a given test is meant to pass or fail, you have to go check the expected/ folder to see if there's an output file there or not. That's slightly annoying. Could we also indicate that something is meant to fail in the filename? Like a _FAIL at the end or something.

Then we can add a lint that verifies that every test ending in _FAIL lacks an expected file, and vice versa, to make sure these two signals don't drift out of date.

@zkat
Copy link
Member

zkat commented Jan 7, 2024

That would be nice yes. The suffix would absolutely be easiest (maybe keep it lowercase because git can get weird with casing in some OSes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants