Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(http-add-on): chart cli args mismatch #475

Closed
wants to merge 1 commit into from

Conversation

kingdonb
Copy link

There's a regression in the latest chart release (0.5.1) and the error output suggested a simple change would fix it (twice)

flag provided but not defined: -enable-leader-election
Usage of /sbin/init:
  -admin-port int
    	The port on which to run the admin server. This is the port on which RPCs will be accepted to get the routing table (default 9090)
  -health-probe-bind-address string
    	The address the probe endpoint binds to. (default ":8081")
  -kubeconfig string
    	Paths to a kubeconfig. Only required if out-of-cluster.
  -leader-elect
    	Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
  -metrics-bind-address string
    	The address the metric endpoint binds to. (default ":8080")

The similar error for metrics-addr, I tested this change locally (and everything seems fine after changing these two command line args to be in line with the latest app release!)

I'll check my DCO and rebase to sign-off if needed, I just wanted to upstream this since I found it.

Provide a description of what has been changed

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #

There's a regression in the latest chart release (0.5.1) and the error output suggested a simple change would fix it (twice)

Signed-off-by: Kingdon Barrett <[email protected]>
@kingdonb kingdonb requested a review from a team as a code owner June 21, 2023 20:03
@kingdonb kingdonb changed the title Fix keda-add-ons-http chart (cli args mismatch) fix:(http-add-on): chart cli args mismatch Jun 21, 2023
@JorTurFer
Copy link
Member

Thanks for the fix!
There were more changes pending to move, this other PR addresses all of them: #474

@kingdonb
Copy link
Author

Sorry this looks like it's already been in #474

@kingdonb kingdonb closed this Jun 21, 2023
@JorTurFer
Copy link
Member

Sorry this looks like it's already been in #474

No worries, thanks a lot for the fix 🙇 I think that tomorrow morning will be merged and released

@kingdonb kingdonb deleted the patch-1 branch June 21, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants