Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add forgotten crds.additionalAnnotations to crd-cloudeventsources.yaml #668

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

Farfaday
Copy link
Contributor

@Farfaday Farfaday commented Jul 29, 2024

Add forgotten block to template crds.additionalAnnotations into crd-cloudeventsources.yaml annotations.

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

@Farfaday Farfaday requested a review from a team as a code owner July 29, 2024 08:27
@JorTurFer
Copy link
Member

Thanks!

@JorTurFer JorTurFer merged commit 59bca22 into kedacore:main Jul 31, 2024
36 checks passed
JorTurFer pushed a commit to JorTurFer/charts that referenced this pull request Jul 31, 2024
…s.yaml (kedacore#668)

Signed-off-by: François Blondel <[email protected]>
Co-authored-by: François Blondel <[email protected]>
JorTurFer pushed a commit to JorTurFer/charts that referenced this pull request Jul 31, 2024
…s.yaml (kedacore#668)

Signed-off-by: François Blondel <[email protected]>
Co-authored-by: François Blondel <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer added a commit that referenced this pull request Jul 31, 2024
* fix: labels on cloudeventsources CRD should be the same as other CRDs (#656)

Signed-off-by: Joel Dimbernat <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* chore: Update comments and suggested defaults (#651)

Signed-off-by: Kamil Aliev <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* fix: broken "| default" logic for automountServiceAccountToken (#665)

When setting (.Values.serviceAccount.operator).automountServiceAccountToken to boolean false, the "| default" part kicks in.
Fix is strongly inspired from helm/helm#12080 (comment)

Signed-off-by: François Blondel <[email protected]>
Co-authored-by: François Blondel <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* fix: add forgotten crds.additionalAnnotations to crd-cloudeventsources.yaml (#668)

Signed-off-by: François Blondel <[email protected]>
Co-authored-by: François Blondel <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* Prepare release v2.14.3

Signed-off-by: Jorge Turrado <[email protected]>

---------

Signed-off-by: Joel Dimbernat <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Kamil Aliev <[email protected]>
Signed-off-by: François Blondel <[email protected]>
Co-authored-by: JoelDimbernat <[email protected]>
Co-authored-by: Kamil Aliev <[email protected]>
Co-authored-by: François Blondel <[email protected]>
Co-authored-by: François Blondel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants