Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a helm chart just for the CRDs like karpenter does #5575

Open
ecerulm opened this issue Mar 6, 2024 · 6 comments · May be fixed by kedacore/charts#675
Open

Provide a helm chart just for the CRDs like karpenter does #5575

ecerulm opened this issue Mar 6, 2024 · 6 comments · May be fixed by kedacore/charts#675
Assignees
@ecerulm
Labels
feature All issues for new features that have been committed to

Comments

@ecerulm
Copy link

ecerulm commented Mar 6, 2024

Proposal

The CRDs can today be installed from the regular helm chart kedacore/keda but it's often good to have the the crds as an independent helm chart for example Karpenter provider karpenter and karpenter-crd

Use-Case

The rationale for that is for upgrades see Karpenter CRD Upgrades

In karpenter , the karpenter helm chart only installs the CRDs on first installation, subsequent chart upgrades will not add or remove CRDs, even if the CRDs have changed.

Having a separate helm chart for CRDs gives more control and allows me to deploy the CRDs from terraform (today this project provides the crds as a single file like https://github.com/kedacore/keda/releases/download/v2.13.1/keda-2.13.1-crds.yaml which is harder to deploy from a terraform perspective it's much easier if it's a helm release.

In any case it should be stated (here or in the documentation) what happens with the CRDs during an helm upgrade. It's my understanding by looking at the source code https://github.com/kedacore/charts/blob/main/keda/templates/crds/crd-triggerauthentications.yaml that today keda helm chart will always overwrite.

Is this a feature you are interested in implementing yourself?

Maybe

Anything else?

No response
@ecerulm ecerulm added feature-request All issues for new features that have not been committed to needs-discussion labels Mar 6, 2024
@stale Stale
Copy link

stale bot commented May 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label May 5, 2024
@tomkerkhove tomkerkhove removed the stale All issues that are marked as stale due to inactivity label May 6, 2024
@JorTurFer
Copy link
Member

WDYT @tomkerkhove @zroubalik ?

@tomkerkhove
Copy link
Member

tomkerkhove commented May 16, 2024 •
edited
Loading

No objections, as long as Helm chart updates effectively update CRDs as well! I know there were some issues in that direction as part of kedacore/charts#226

@tomkerkhove
Copy link
Member

Are you willing to contribute this @ecerulm ?

@ecerulm
Copy link
Author

ecerulm commented May 31, 2024

yes, I can do this .

@tomkerkhove tomkerkhove added feature All issues for new features that have been committed to and removed feature-request All issues for new features that have not been committed to needs-discussion labels May 31, 2024
@ecerulm ecerulm linked a pull request Aug 5, 2024 that will close this issue
Open
4 tasks
@tomkerkhove
Copy link
Member

Duplicate of kedacore/charts#226

@tomkerkhove tomkerkhove marked this as a duplicate of kedacore/charts#226 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecerulm ecerulm

Labels
feature All issues for new features that have been committed to
Projects
Roadmap - KEDA Core
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add keda-crd helm chart ecerulm/kedacore-charts
3 participants
@ecerulm @tomkerkhove @JorTurFer