-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kedro-telemetry
: Introduce environment variables for disabling telemetry and revise disabling methods
#728
Comments
Does this conflict with #726? We should not counsel users to remove mandatory dependencies to avoid having
Wondering if this granularity is excessive. I wouldn't see users wanting to disable telemetry for some commands, but not others. |
kedro-telemetry
: Introduce environment variables for disabling telemetry and revise disabling methods
Maybe we could mention this as a "last resort" solution. But also say we don't advice doing this because |
Few questions for @DimedS :
|
About --no-telemetry, we couldn't think of cases in which users would opt out for some commands, but not others. It's annoying to type every time too. I think it's not worth adding. |
Description
Part of #715:
Introduce two new environment variables for disabling telemetry:
DO_NOT_TRACK
KEDRO_DISABLE_TELEMETRY
When either of these variables is set to True or 1, telemetry should not be used. This will have the same effect as setting
consent: false
in the.telemetry
file, but without the need to modify the file. We will only check the consent.Context
Detailed explanation provided by @astrojuanlu in this comment.
When all the opt-out tasks for #715 are completed these should be the ways to disable telemetry:
Set the environment variables
DO_NOT_TRACK
orKEDRO_DISABLE_TELEMETRY
to 1. Setting either of these variables will fully disable telemetry for all projects in that environment.Create a
.telemetry
file in the root folder of the Kedro project and write thereconsent: false
. This disables telemetry for any kedro command executed within that project's folder.When creating a new project, users can use the command
kedro new --telemetry=yes/no
. This will create a.telemetry
file withconsent: true/false
accordingly. However, telemetry data about the execution of the kedro new command will still be sent afterkedro-telemetry
: Spike how to enable telemetry for "kedro new" and other commands executed outside of kedro project folder #729 implementation.pip uninstall kedro-telemetry
Previously, we attempted to implement a CLI consent disable for
kedro run
command (see Issue 2867), but it was reverted due to unclear initial design. Considering the shift to an opt-out model, I believe @ankatiyar's proposal to provide consent for each execution of certain Kedro commands is still relevant.Let's discuss this proposal:
--no-telemetry
flag forkedro run
and possibly other commands:kedro run --no-telemetry
.The text was updated successfully, but these errors were encountered: