Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest kedro load and save breaks mypy on datasets #793

Closed
noklam opened this issue Jul 31, 2024 · 1 comment · Fixed by #829
Closed

Latest kedro load and save breaks mypy on datasets #793

noklam opened this issue Jul 31, 2024 · 1 comment · Fixed by #829
Assignees
@deepyaman

Comments

@noklam
Copy link
Contributor

noklam commented Jul 31, 2024

Description

kedro_datasets/pandas/json_dataset.py:210: error: "AbstractDataset[Any, Any]" has no attribute "_load"; maybe "load"? [attr-defined]

https://github.com/kedro-org/kedro-plugins/actions/runs/10181415594/job/28161510649?pr=786

The root cause is now dataset cannot find the _load method as it's looking for signature of AbstractDataset, while the _load is implemented in JSONDataset

Potential Fix

Use generic type instead of returing AbstractDataset in https://github.com/kedro-org/kedro/blob/8bbbfb6c7257005bef841143690308f05d4b829b/kedro/io/core.py#L403-L407
@deepyaman deepyaman self-assigned this Jul 31, 2024
@deepyaman
Copy link
Member

deepyaman commented Jul 31, 2024 •
edited
Loading

I'll update the datasets to define public load and save.

@deepyaman deepyaman mentioned this issue Sep 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepyaman deepyaman

Labels
None yet
Projects
Kedro Framework
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(datasets)!: expose load and save publicly kedro-org/kedro-plugins
2 participants
@deepyaman @noklam