-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with 1.7.1 kedro-datasets release #1558
Comments
Hi @ravi-kumar-pilla , what broke? Do you have a URL of a failing build? |
Hi Juan, The circle ci builds are failing - https://app.circleci.com/pipelines/github/kedro-org/kedro-viz/10632/workflows/a8d8d61d-132a-4a48-8990-1ffa51bd422b/jobs/60837 |
I see - if I understand correctly, technically yeah this is a breaking change from 1.7.0 to 1.7.1 right? so maybe there's something to be done on the datasets side. cc @ankatiyar @merelcht |
Changing DataSet -> Dataset in the tests should fix this I think |
Yes that would fix it. I'm surprised that the tests started failing, because the aliases are still in place.. It might be because of hardcoded |
Yeah, you can still create datasets with
|
Thank you for the suggestions. As a quick fix, we decided to pin down kedro-datasets version to 1.7 in the requirements file. We will be adding support for kedro datasets 1.7.1 and above in the upcoming sprints. Thank you |
With Kedro Datasets 1.7.1 release , we need to update the dataset imports and fix pytests
We will be pinning down the dependency of kedro datasets to 1.7.0 as a quick fix
The text was updated successfully, but these errors were encountered: