Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] sepolia deployment #27

Open
glihm opened this issue Mar 26, 2024 · 10 comments
Open

[feat] sepolia deployment #27

glihm opened this issue Mar 26, 2024 · 10 comments
Labels
tooling Tool around piltover

Comments

@glihm
Copy link
Collaborator

glihm commented Mar 26, 2024

The idea of this PR is to implement the tooling around piltover to easily deploy the contract on Sepolia.

This includes:

  1. Compiling the contracts
  2. Deploying the contracts configured to interact with the herodotus verifier, list of deployments is here.
  3. Documenting this process to be easily repeatable by user.

To achieve this task, several options:

  1. Bash script with Starkli
  2. Starknet foundry scripting
  3. Rust program using starknet-rs

We could give a try to the option 2 even if it still experimental and the API may change in the future. @b-j-roberts @drspacemn @EvolveArt what do you think it's better?
If we go with 3, it could be a dedicated command line tool for piltover. But more stuff to maintain.

@glihm glihm added the tooling Tool around piltover label Mar 26, 2024
@drspacemn
Copy link
Contributor

drspacemn commented Mar 27, 2024

I would also vote for option 2 here, happy with 1 , but would prefer not to do 3.

@EvolveArt
Copy link
Collaborator

If we align with what is done on zaun side we should go with option 3. As you mentionned option 2 is still experimental and option 3 gives us more flexibility. To be fair it's not that much code.

@drspacemn
Copy link
Contributor

@EvolveArt this is just what was merged on blobstream-starknet what are your thoughts on this vs what is done in zaun?

@thomas192
Copy link
Contributor

Hey, I can work on this after it's been discussed

@glihm
Copy link
Collaborator Author

glihm commented Sep 6, 2024

@thomas192 still around and interested to do so? Let's try with 3 rust code if you feel confortable with it.

Copy link

onlydustapp bot commented Sep 6, 2024

Hey @glihm!
Thanks for showing interest.
We've created an application for you to contribute to Blobstream-Starknet.
Go check it out on OnlyDust!

@byteZorvin
Copy link
Contributor

byteZorvin commented Oct 19, 2024

Hey if this is open to be taken up, I would like to work on this @glihm

@glihm
Copy link
Collaborator Author

glihm commented Oct 31, 2024

@byteZorvin yup! Which direction would you want to take for the deployment Strat? Adding this to cainome could make the deployment process very easy from rust. :)

@byteZorvin
Copy link
Contributor

Yes makes sense, even I lean towards starknet.rs scripts. If this sounds good can proceed @glihm

@glihm
Copy link
Collaborator Author

glihm commented Nov 7, 2024

Sounds great @byteZorvin! You can go with starknet.rs script for now if you prefer and we can refactor later once cainome supports declare/deploy. 👍
Or happy to have PRs on cainome if you feel about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Tool around piltover
Projects
None yet
Development

No branches or pull requests

5 participants