Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev] Commitment Verification Trait #30

Open
drspacemn opened this issue Apr 18, 2024 · 2 comments
Open

[dev] Commitment Verification Trait #30

drspacemn opened this issue Apr 18, 2024 · 2 comments
Assignees
@Oshioke-Salaki
Labels
dev Non-functional work

Comments

@drspacemn
Copy link
Contributor

Piltover will call both is_valid on the verifier contract with the DA fact, and also verify_attestation on the blobstream contracts in order to ensure a valid state update.

Since blobstream is not the only means by which an appchain can prove it's data commitment this should be a generic trait that verifies its input with a verify_attestation call.
@drspacemn drspacemn added the dev Non-functional work label Apr 18, 2024
@drspacemn drspacemn changed the title [dev] Generic Commitment Verification [dev] Commitment Verification Trait Apr 18, 2024
@Oshioke-Salaki
Copy link

Hey please can i be assigned this?

@drspacemn
Copy link
Contributor Author

@Oshioke-Salaki sorry for the delay. This has been assigned to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Oshioke-Salaki Oshioke-Salaki

Labels
dev Non-functional work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drspacemn @Oshioke-Salaki