From d823aaa7b40597e1ccfa7967c6f2307fd4e4fc26 Mon Sep 17 00:00:00 2001 From: sbadiger Date: Thu, 31 Aug 2023 11:47:47 -0700 Subject: [PATCH] update defaultScalingConfiguration flag description Signed-off-by: sbadiger --- controllers/instancegroup_controller.go | 2 +- main.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/controllers/instancegroup_controller.go b/controllers/instancegroup_controller.go index 76e6d86b..47412ce3 100644 --- a/controllers/instancegroup_controller.go +++ b/controllers/instancegroup_controller.go @@ -195,7 +195,7 @@ func (r *InstanceGroupReconciler) Reconcile(ctxt context.Context, req ctrl.Reque ctx = eksfargate.New(input) } - // for igs without any config type mentioned, allow the default to be set to launchconfig. + // for igs without any config type mentioned, allow overriding the default. overrides := v1alpha1.NewValidationOverrides(r.DefaultScalingConfiguration) if err = input.InstanceGroup.Validate(overrides); err != nil { diff --git a/main.go b/main.go index 65497fce..caa606db 100644 --- a/main.go +++ b/main.go @@ -88,7 +88,7 @@ func main() { "Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.") flag.BoolVar(&nodeRelabel, "node-relabel", true, "relabel nodes as they join with kubernetes.io/role label via controller") flag.BoolVar(&disableWinClusterInjection, "disable-windows-cluster-ca-injection", false, "Setting this to true will cause the ClusterCA and Endpoint to not be injected for Windows nodes") - flag.StringVar(&defaultScalingConfiguration, "", string(instancemgrv1alpha1.LaunchTemplate), "By default ASGs will have launchtemplates. Set this flag to true if launchconfigs needs to be the default.") + flag.StringVar(&defaultScalingConfiguration, "", string(instancemgrv1alpha1.LaunchTemplate), "By default ASGs will have LaunchTemplate. Set this string to either 'LaunchConfiguration' or 'LaunchTemplate' to enforce defaults.") flag.Parse() ctrl.SetLogger(zap.New(zap.UseDevMode(true)))