Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drainTimeout is not used in WaitForTermination #140

Open
uthark opened this issue Nov 14, 2020 · 0 comments
Open

drainTimeout is not used in WaitForTermination #140

uthark opened this issue Nov 14, 2020 · 0 comments

Comments

@uthark
Copy link
Contributor

uthark commented Nov 14, 2020

Is this a BUG REPORT or FEATURE REQUEST?:
Bug
What happened:
use case I observed:

  1. rollingUpgrade has drainTimeout configured (7 mins)
  2. postDrain helper script fails.
  3. drainTimeout specifies Node will be terminated after drain timeout even if kubectl drain has not been completed
  4. WaitForTermination ignores DrainTimeout and uses const of 1h https://github.com/keikoproj/upgrade-manager/blob/master/controllers/rollingupgrade_controller.go#L270-L273

What you expected to happen:
If drain timeout is configured, then wait for termination should use it OR provide another field in spec to configure the timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant