Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment manifest removed / readme needs updating #336

Open
preflightsiren opened this issue Jul 11, 2022 · 3 comments
Open

Deployment manifest removed / readme needs updating #336

preflightsiren opened this issue Jul 11, 2022 · 3 comments

Comments

@preflightsiren
Copy link

Is this a BUG REPORT or FEATURE REQUEST?: Bug report

What happened: https://raw.githubusercontent.com/keikoproj/upgrade-manager/master/deploy/rolling-upgrade-controller-deploy.yaml was deleted as part of 167e10b and a replacement manifest has not been provided, nor the readme has been updated with new deployment instructions.

What you expected to happen: Either a replacement exists, or new instructions on how to deploy the controller provided.

How to reproduce it (as minimally and precisely as possible): n/a

Anything else we need to know?: n/a

@preflightsiren
Copy link
Author

found that kustomize build https://github.com/keikoproj/upgrade-manager.git/config/default\?ref\=v1.0.2 might be the best way to support creating these manifests.

@shreyas-badiger
Copy link
Collaborator

@preflightsiren Did you try doing a make manifests followed by a make install?

@preflightsiren
Copy link
Author

@shreyas-badiger this isn't being run from within the codebase. I have a repo that contains all my clusters configuration, part of that repo we have vendored manifests eg.

      - rm -rf {{.VENDORDIR}}; mkdir -p {{.VENDORDIR}}
      - wget --quiet -N https://raw.githubusercontent.com/keikoproj/instance-manager/{{.VERSION}}/config/crd/bases/instancemgr.keikoproj.io_instancegroups.yaml -O {{.VENDORDIR}}/crd.yaml
      - wget --quiet -N https://raw.githubusercontent.com/keikoproj/instance-manager/{{.VERSION}}/config/crd/bases/instance-manager-deployment.yaml -O {{.VENDORDIR}}/deployment.yaml
      - wget --quiet -N https://raw.githubusercontent.com/keikoproj/instance-manager/{{.VERSION}}/config/rbac/role.yaml -O {{.VENDORDIR}}/role.yaml

for upgrade-manager I have:

      - rm -rf {{.VENDORDIR}}; mkdir -p {{.VENDORDIR}}
      - wget --quiet -N https://raw.githubusercontent.com/keikoproj/instance-manager/{{.VERSION}}/config/crd/bases/instancemgr.keikoproj.io_instancegroups.yaml -O {{.VENDORDIR}}/crd.yaml
      - wget --quiet -N https://raw.githubusercontent.com/keikoproj/instance-manager/{{.VERSION}}/config/crd/bases/instance-manager-deployment.yaml -O {{.VENDORDIR}}/deployment.yaml
      - wget --quiet -N https://raw.githubusercontent.com/keikoproj/instance-manager/{{.VERSION}}/config/rbac/role.yaml -O {{.VENDORDIR}}/role.yaml

I don't imagine most larger deployments will want to manually apply configuration, especially without additional customisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants