Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Update to work against ember 3.28+ ? #336

Open
sly7-7 opened this issue Sep 7, 2021 · 4 comments
Open

[Question] Update to work against ember 3.28+ ? #336

sly7-7 opened this issue Sep 7, 2021 · 4 comments

Comments

@sly7-7
Copy link

sly7-7 commented Sep 7, 2021

Hello,

I'm working with @NullVoxPopuli on updating ember-moment. It turns out the test suite doesn't pass because of this addon not beeing compatible with ember >3.28. The question is, since I believe (maybe I'm wrong) we want to move away from computed properties, do you want to make it compatible with ember 3.28+, or deprecate it ?
For information, this addon is erroring when we want to compose macros.
For example, this test, https://github.com/kellyselden/ember-macro-helpers/blob/master/tests/acceptance/monkey-patch-test.js
Capture d’écran 2021-09-07 à 09 10 01

@kellyselden
Copy link
Owner

I won't be spending time updating it. So I can deprecate it if you prefer.

@sly7-7
Copy link
Author

sly7-7 commented Sep 9, 2021

@kellyselden It's ok for me to deprecate this addon. I think we have decided to get rid of computed properties in ember-moment, ember-macro-helpers would not be necessary in future versions.
That beeing said, I don't know all addons relying on it, and maybe in the community, a lot of people would be interrested in migration. (even if I don't know what that means, because I guess computed properties are not recommended anymore when using ember.js)

@kellyselden
Copy link
Owner

This library is using ember internals that probably don't exist anymore. It may be impossible to support newer versions of ember.

@tythewebguy
Copy link

This add-on broke Ember while upgrading to 3.27 and I spent way too much time tracking it down. Since it's no longer going to be updated, it could be very helpful to others if it's clearly marked as deprecated in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants