-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Update to work against ember 3.28+ ? #336
Comments
I won't be spending time updating it. So I can deprecate it if you prefer. |
@kellyselden It's ok for me to deprecate this addon. I think we have decided to get rid of computed properties in ember-moment, ember-macro-helpers would not be necessary in future versions. |
This library is using ember internals that probably don't exist anymore. It may be impossible to support newer versions of ember. |
This add-on broke Ember while upgrading to 3.27 and I spent way too much time tracking it down. Since it's no longer going to be updated, it could be very helpful to others if it's clearly marked as deprecated in the readme. |
Hello,
I'm working with @NullVoxPopuli on updating ember-moment. It turns out the test suite doesn't pass because of this addon not beeing compatible with ember >3.28. The question is, since I believe (maybe I'm wrong) we want to move away from computed properties, do you want to make it compatible with ember 3.28+, or deprecate it ?
For information, this addon is erroring when we want to compose macros.
For example, this test, https://github.com/kellyselden/ember-macro-helpers/blob/master/tests/acceptance/monkey-patch-test.js
The text was updated successfully, but these errors were encountered: