Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showing links in editing mode #11

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Showing links in editing mode #11

wants to merge 8 commits into from

Conversation

johnbillion
Copy link

@johnbillion johnbillion commented Apr 5, 2023 •
edited
Loading

Fixes #1.

Shows the smart links while in editing mode.

Work in progress, but it's functional.

Todo

  • Better positioning/formatting for the link
  • Don't operate when in Source mode
  • Allow for more than one instance of each matching link
  • Order returned decorations by from position ascending (triggers a JavaScript error when they're returned out of order)
  • Unit tests
  • Documentation

Screenshot

@johnbillion
Copy link
Author

I haven't had time to continue working on this lately. Up until 69662ba this works nicely in Live Preview mode, but in cbe2484 I changed the appearance and hid it in Source Mode and it has caused the app to lock up when editing text around the links, so that needs to be revisited.

@kemayo
Copy link
Owner

kemayo commented May 25, 2023

Thank you for that -- I've been busy with work and traveling, but I'll try to take a look at it once I'm home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miggi92 miggi92 miggi92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make work in editing mode
3 participants
@johnbillion @kemayo @miggi92