Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor profile_overrides.js #37

Open
kennethjiang opened this issue Feb 10, 2017 · 0 comments
Open

Refactor profile_overrides.js #37

kennethjiang opened this issue Feb 10, 2017 · 0 comments
Labels
enhancement low

Comments

@kennethjiang
Copy link
Owner

kennethjiang commented Feb 10, 2017 •
edited
Loading

Refactor profile_overrides.js to elevate the following issues:

  • profile entries of Cura and Slic3r may share the same name but different types (one is array the other is not).
  • Jinja files for Cura and Sli3r are mingled which make it hard to maintain.
  • A general way to pre/post-process data, such as converting string <-> float, or removing "%"
  • Base class OverridesViewModel may be a bad idea. It causes any event to be fired twice, once for BasicOverridesViewModel and second time for AdvancedOverridesViewModel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kennethjiang