Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux devtools #124

Open
davidmoshal opened this issue Jan 31, 2016 · 3 comments
Open

Redux devtools #124

davidmoshal opened this issue Jan 31, 2016 · 3 comments

Comments

@davidmoshal
Copy link

This could well be the best React developer experience out there:

  • static typing
  • hot reloading using the latest React Transform

One thing that would be awesome would be to include the Redux Devtools:

Thanks for keeping the dependencies up-to-date

David

@davidmoshal
Copy link
Author

Actually, I got this working, with only a couple of line changes, and nothing else installed!

  1. changed createStore in index.tsx
declare var window:any;

function configureStore():Store {
  const store:Store = createStore(
    counterApp,
    {counters: []},
    window.devToolsExtension ? window.devToolsExtension() : undefined
  );

 // the rest of the function is unchanged
  1. changed the createStore definition in redux.d.ts
    function createStore(reducer: Reducer, initialState?: any, opts?:any): Store;

Apparently the optional 3rd parameter is new in redux 3.1 onwards.

@keokilee
Copy link
Owner

Thanks for the kind words! Having this wrapped up in a PR maybe would be nice.

Personally, I think the one thing that's missing is testing. After that, then it'd be one step closer to world domination the best React dev experience out there 😄

@davidmoshal
Copy link
Author

fair point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants