Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Make a Darkmode ICON for the Plugin #191

Open
phoenix-necro opened this issue Oct 25, 2021 · 3 comments
Open

Feature Request: Make a Darkmode ICON for the Plugin #191

phoenix-necro opened this issue Oct 25, 2021 · 3 comments
Assignees
Labels
comp: popup Generic extension popup issues impact: low type: bug Bug reports
Milestone

Comments

@phoenix-necro
Copy link

Please make an ICON that will work in dark mode so the color picker is not obscured

image

@kepi kepi self-assigned this Oct 31, 2021
@kepi kepi added this to the v0.5.x bugfixes milestone Oct 31, 2021
@kepi
Copy link
Owner

kepi commented Oct 31, 2021

Thanks for report. I'm not using Chrome much so I didn't realize there is now convenient dark mode.

I'll take a look at it when there is a time.

@kepi kepi added type: bug Bug reports comp: popup Generic extension popup issues labels May 28, 2022
@kepi
Copy link
Owner

kepi commented May 28, 2022

Looks like there is unfortunately no API to easily replace icon in Dark Mode. I'll try to create some universal icon which will be visible on both light/dark background, not sure it will work.

Pull requests with proposed icon welcomed :)

@kepi kepi modified the milestones: v0.5.x bugfixes, v1.2.x.y, feature Jul 1, 2024
@kepi
Copy link
Owner

kepi commented Oct 29, 2024

This is now implemented in Firefox version. Chrome will need some more convincing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: popup Generic extension popup issues impact: low type: bug Bug reports
Projects
None yet
Development

No branches or pull requests

2 participants