Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed keras tuner fails in case when chief oracle server startup takes more than 5 minutes #990

Open
onponomarev opened this issue Mar 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@onponomarev
Copy link
Contributor

We observed that in some cases distributed keras tuner fails.

It's caused by the fix to prevent keras tuner hanging forever - 5 min RPC timeouts were introduced (see #957).
Now if keras chief worker startup takes longer than 5 minutes, then the client gives up and fails the whole tuning process.

Normally RPC server startup is quick, but in some cases it might take slightly longer.

The planned solution is to increase the client timeout to 1h. We still need the timeout to prevent tuner clients from hanging forever. We need the timeout to be high enough so that chief oracle server always has enough time to start.

@onponomarev onponomarev added the bug Something isn't working label Mar 4, 2024
onponomarev added a commit to onponomarev/keras-tuner that referenced this issue Mar 4, 2024
The timeout is so high to prevent a rare race condition from happening.
We need clients to wait till chief oracle server starts. This normally takes
a few minutes, but sometimes might take longer.
See keras-team#990 for more details.
Initially we didn't have any timeout. It was introduced to avoid tuner jobs
hanging forever if chief oracle stops responding.
See keras-team#957.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant