-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl+Space not opening the Conex popup [FF 59.0b7 on Mac OS] #154
Comments
That’s weird, as this is basically my setup as well (60.0a1 instead of 59.0b7)
… On 7. Feb 2018, at 17:45, Felipe Turcheti ***@***.***> wrote:
The shortcut to open the Conex popup – Ctrl+Space – is not working here. I'm running Firefox Quantum 59.0b7 on Mac OS Sierra 10.12.6.
To make sure this is not related to other extensions or custom settings, I've cloned Conex and tested it with web-ext run, but the problem persisted.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#154>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAvjT9h2w6LWg-Krvx4qZEb0hUViCa9ks5tSdNFgaJpZM4R9Bs3>.
|
do you have a mac os x wide shortcut mapped to this combination? |
Yes, that's indeed weird... I tried to disable some tools that could be causing some conflict but I didn't find the the source of the problem yet. Anyway, if I'm the only one facing this issue it must be something with my system. I'll try to investigate a bit further and if I discover something I'll come back with more information. |
I just found the shortcut that was causing this conflict. It seems that ––– [1]: If you're not seeing these "Input Sources" shortcuts, you have to add multiple input sources first. |
@fturcheti conex has been through 4 or 5 different shortcuts and there's always something that conflicts. It really ought to be configurable, but that's a whole 'nother problem. Honestly it really feels like a Firefox bug that users can't configure extension hotkeys. |
yeah ... who would have thought, that keyboard shortcuts is one of the hardest problems :/ Thanks, I'll try to think about something |
@smichel17 I totally agree, it would be much better if Firefox had an easy way to set these shortcuts. Defining a hard-coded is certainly a difficult task, it will always bring problems to someone. @kesselborn if I can remember, there wasn't a shortcut to "move a tab to another group" in the original TabGroups. I think the default shortcuts were:
|
Mmm … there was a shortcut to open the popup and search for tabs as well — somebody remembers? :)
… On 14. Feb 2018, at 11:34, Felipe Turcheti ***@***.***> wrote:
@smichel17 <https://github.com/smichel17> I totally agree, it would be much better if Firefox had an easy way to set these shortcuts. Defining a hard-coded is certainly a difficult task, it will always bring problems to someone.
@kesselborn <https://github.com/kesselborn> if I can remember, there wasn't a shortcut to "move a tab to another group" in the original TabGroups. I think the default shortcuts were:
Cmd+Shift+e: Show tab groups (the grid overview or the smaller popup according to the user setup)
Ctrl+`: Go to next group
Ctrl+Shift+`: Go to previous group
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#154 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAvjV5tapgOktG9cMXgC5X99K3-J5laks5tUrbTgaJpZM4R9Bs3>.
|
Looking at the source code, it seems that there wasn't a default shortcut for this action: https://github.com/Quicksaver/Tab-Groups/blob/master/resource/defaults.js#L45 I remember to use But if you don't want to go with |
Mmm … vivaldies Quick Command (which has some similarities) opens via `Cmd+e` … so, `<some combination>+e` does not seem so bad.
As this is still experimental and < 1.0.0, I guess I could argue that breaking changes can still happen ;)
… On 14. Feb 2018, at 12:44, Felipe Turcheti ***@***.***> wrote:
Looking at the source code, it seems that there wasn't a default shortcut for this action: https://github.com/Quicksaver/Tab-Groups/blob/master/resource/defaults.js#L45 <https://github.com/Quicksaver/Tab-Groups/blob/master/resource/defaults.js#L45>
I remember to use Cmd+Shift+E for opening the Tab Groups popup, as I preferred this compact mode instead of the grid view. "Simplified Tab Groups for Firefox", another add-on in the lineage of Quicksaver's Tab Groups (and the one I was using before FF57), also uses Cmd+Shift+E as the shortcut for displaying its tab groups popup: https://github.com/denschub/firefox-tabgroups/blob/develop/src/index.js#L89 <https://github.com/denschub/firefox-tabgroups/blob/develop/src/index.js#L89>
But if you don't want to go with Cmd+Shift+E, another suggestion is to choose Cmd+Shift+\, as Safari uses this shortcut for showing its tabs overview.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#154 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAvjbRZbVW6F7Z-0BBZhZeOvkJLXeZYks5tUscLgaJpZM4R9Bs3>.
|
Maybe you could change the shortcuts to:
|
yeah: `Ctrl+Shift+M` was move before but is as well a combination that is already used (see kesselborn/conex#85 ).
I was thinking
- `Cmd+Shift+E` for move and `Cmd+E` for popup … but I am not sure `Cmd+E` will work (for non macos replace `Cmd` by `Ctrl` )
EDIT: `Cmd+E` does not work …. ` MacCtrl+E` does though … not sure what that would mean for Windows / Linux though.
/me is annoyed
… On 14. Feb 2018, at 14:29, Felipe Turcheti ***@***.***> wrote:
Maybe you could change the shortcuts to:
Cmd+Shift+E: open the popup
Cmd+Shift+M: move tabs between groups
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#154 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAvjQT10GkTQkZYqF3OJwnFdXIUMJT9ks5tUt_HgaJpZM4R9Bs3>.
|
I personally didn't love this one because I accidentally hit |
@kesselborn I think the better solution for the moment is to leave the shortcuts as they are and advert users about this possible conflict, also indicating that Firefox will soon provide the API for webextensions to change predefined shortcuts. I always get lost navigating these Firefox bugs, but it seems that this functionality is really coming: https://bugzilla.mozilla.org/show_bug.cgi?id=1421811 |
Oh … 💗 — it sounds indeed as if it’ll be in v60.
Awesome: I track quite some keyboard shortcut bugs, but this one I did not :)
Cheers
… On 14. Feb 2018, at 15:29, Felipe Turcheti ***@***.***> wrote:
@kesselborn <https://github.com/kesselborn> I think the better solution for the moment is to leave the shortcuts as they are and advert users about this possible conflict, also indicating that Firefox will soon provide the API for webextensions to change predefined shortcuts.
I always get lost navigating these Firefox bugs, but it seems that this functionality is really coming: https://bugzilla.mozilla.org/show_bug.cgi?id=1421811 <https://bugzilla.mozilla.org/show_bug.cgi?id=1421811>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#154 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAvjR1YsYDgBgz6-ihqB87cTWMD4f8Cks5tUu22gaJpZM4R9Bs3>.
|
closing this for #155 as custom remappings will solve your problem as well ... thanks for the investigation @fturcheti |
fixed in dc3b963 (v0.3.0) |
The shortcut to open the Conex popup –
Ctrl+Space
– is not working here. I'm running Firefox Quantum 59.0b7 on Mac OS Sierra 10.12.6.To make sure this is not related to other extensions or custom settings, I've cloned Conex and tested it with
web-ext run
, but the problem persisted.The text was updated successfully, but these errors were encountered: