From 7578b1dbddba5f57dc9a3f9ab2423226eb1f5ba0 Mon Sep 17 00:00:00 2001 From: Kesavan Yogeswaran Date: Sun, 4 Feb 2024 11:40:02 -0500 Subject: [PATCH 1/2] Configure rustfmt action in review mode This prevents the action from creating new commits --- .github/workflows/build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 20c78fd..8ec3eb6 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -21,9 +21,10 @@ jobs: toolchain: stable components: clippy, rustfmt - name: rustfmt - uses: mbrobbel/rustfmt-check@0.7.0 + uses: mbrobbel/rustfmt-check@0.8.1 with: token: ${{ secrets.GITHUB_TOKEN }} + mode: review - name: clippy uses: clechasseur/rs-clippy-check@v2 with: From 11085b3c947a3e3a8ce1b7edcd3db0ddb647bc51 Mon Sep 17 00:00:00 2001 From: Kesavan Yogeswaran Date: Sun, 4 Feb 2024 11:40:33 -0500 Subject: [PATCH 2/2] Minor doc tweaks * The streak is longer now * Use generic docker image name --- .github/workflows/build.yml | 24 ++++++++++++------------ README.md | 4 ++-- docker.md | 4 ++-- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8ec3eb6..adc58aa 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -11,25 +11,25 @@ env: jobs: build: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable + - name: Build + run: cargo build --verbose + - name: Run tests + run: cargo test --verbose + fmt: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: dtolnay/rust-toolchain@nightly with: - toolchain: stable components: clippy, rustfmt + - name: clippy + uses: clechasseur/rs-clippy-check@v3 - name: rustfmt uses: mbrobbel/rustfmt-check@0.8.1 with: token: ${{ secrets.GITHUB_TOKEN }} mode: review - - name: clippy - uses: clechasseur/rs-clippy-check@v2 - with: - token: ${{ secrets.GITHUB_TOKEN }} - - name: Build - run: cargo build --verbose - - name: Run tests - run: cargo test --verbose diff --git a/README.md b/README.md index 331a3ef..0954ab7 100644 --- a/README.md +++ b/README.md @@ -6,8 +6,8 @@ When I first subscribed to the _New York Times_ crossword in January 2017, I could solve some Monday puzzles and maybe the occasional Tuesday. Over time, I slowly got better at noticing the common patterns and picked up enough [crosswordese](https://en.wikipedia.org/wiki/Crosswordese) to be able -to finish it fairly consistently. As of February 2021, I've now maintained a daily streak stretching -back 3+ years to August 2017 (knock on wood...). +to finish it fairly consistently. As of February 2024, I've now maintained a daily streak stretching +back 6+ years to August 2017 (knock on wood...). The NYT crossword app exposes some solve time statistics like all-time average and fastest time, both broken out day. But there is no good way to see how much you have improved over time. You can diff --git a/docker.md b/docker.md index 7ef4ad0..256e4bf 100644 --- a/docker.md +++ b/docker.md @@ -12,10 +12,10 @@ gcloud auth login docker build -t `` . # Open a shell in container so you can run commands and test -docker run -it --rm us.gcr.io/xword-stats/xword:latest bash +docker run -it --rm :latest bash # Push image to registry -docker push us.gcr.io/xword-stats/xword:latest +docker push :latest # Use Cloud console to point Cloud Run to latest image ```