Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #441 - Add MdcAdapter for Cats Effect 3 to properly share context through MDC with IO and IOLocal from Cats Effect 3 #467

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevin-lee
Copy link
Owner

Summary

Close #441 - Add MdcAdapter for Cats Effect 3 to properly share context through MDC with IO and IOLocal from Cats Effect 3

@kevin-lee kevin-lee added this to the v2-m2 milestone Jul 29, 2023
@kevin-lee kevin-lee self-assigned this Jul 29, 2023
@github-actions github-actions bot added the pr label Jul 29, 2023
@kevin-lee kevin-lee modified the milestones: v2-m2, v2-m3 Jul 29, 2023
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (83f948d) 97.64% compared to head (c5d29cd) 97.43%.

❗ Current head c5d29cd differs from pull request most recent head 224a48e. Consider uploading reports for the commit 224a48e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
- Coverage   97.64%   97.43%   -0.22%     
==========================================
  Files          15       16       +1     
  Lines         170      195      +25     
  Branches        5       10       +5     
==========================================
+ Hits          166      190      +24     
- Misses          4        5       +1     
Files Coverage Δ
...cala/loggerf/logger/logback/Monix3MdcAdapter.scala 88.00% <100.00%> (ø)
...n/scala/loggerf/logger/logback/Ce3MdcAdapter.scala 95.83% <95.83%> (ø)

... and 3 files with indirect coverage changes

@kevin-lee kevin-lee force-pushed the task/441/mdc-support-for-ce3 branch 6 times, most recently from 2c886b8 to 7fb6b39 Compare July 30, 2023 11:31
@kevin-lee kevin-lee force-pushed the task/441/mdc-support-for-ce3 branch 3 times, most recently from cf1a591 to 65c4002 Compare September 11, 2023 14:52
@kevin-lee kevin-lee marked this pull request as draft October 24, 2023 14:07
@kevin-lee kevin-lee force-pushed the task/441/mdc-support-for-ce3 branch 2 times, most recently from 84d4667 to 1eec151 Compare November 29, 2023 10:56
@kevin-lee kevin-lee force-pushed the task/441/mdc-support-for-ce3 branch 2 times, most recently from dae7d30 to 77cd6ff Compare December 5, 2023 09:59
…xt through MDC with IO and IOLocal from Cats Effect 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MdcAdapter for Cats Effect 3 to properly share context through MDC with IO and IOLocal from Cats Effect 3
1 participant