-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test suite #46
Comments
While I'm in favor of adding these on a high level, want to call 2 things out:
Keeping those in mind I think this is a great idea and would welcome contributions. We don't use react anywhere but in the front end so if there's another suite that the community is more familiar with, let's use that. |
Absolutely - my intention was not to ask you to write a whole test suite. I was mostly trying to gauge what framework might be ideal for testing so we could start introducing some tests as we go along. With #48, I agree that maybe we don't test the front-end logic right away. I'm most familiar with Mocha and Chai, but I feel like that might date me. From what I can tell on the internets, Jest is what a lot of people are using nowadays. |
I'd say Jest or Mocha are both pretty popular still, and we'd be fine using either. Jest has the backing of Facebook, so it gets the nod from React a lot, but either works just fine. If you know Mocha, go with what you know. I'm sure it can handle what we need. |
Hey @blimmer / @bennett39 – just wanted to highlight that we've added some non-exhaustive smoke testing pending the Right now we have two workflows:
We require both of these to pass before merging a PR. For now I'll mark this issue as |
As part of #43, it came up that a unit test suite would be a good addition. In this thread, we could discuss what that might look like technology-wise.
Items to discuss:
Where it builds
It looks like Travis-CI is what's required on branch and PR builds, so likely that should also run the test suite.
Tech stack
I have the most experience with Mocha and Chai but, since this project uses React, something like Jest might be preferable to the other maintainers?
Unit / Integration / Functional Tests
We could easily start off with just unit tests, adding in additional test suites later like component (integration) tests or functional test (e.g. Cypress).
The text was updated successfully, but these errors were encountered: