Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode error #32

Open
wadewegner opened this issue Nov 22, 2016 · 3 comments
Open

Decode error #32

wadewegner opened this issue Nov 22, 2016 · 3 comments

Comments

@wadewegner
Copy link

The presence of ).{% trailing a valid URL (e.g. http://cnn.com/).{%) causes the error:

[PATH]/node_modules/normalize-url/index.js:82
		urlObj.pathname = decodeURI(urlObj.pathname);
		                  ^

URIError: URI malformed
    at decodeURI (native)
    at module.exports ([PATH]/node_modules/normalize-url/index.js:82:21)
    at [PATH]/node_modules/get-urls/index.js:14:10
    at Array.map (native)
    at module.exports ([PATH]/node_modules/get-urls/index.js:13:24)
    at [PATH]/index.js:17:16
    at Array.forEach (native)
    at [PATH]/index.js:15:9
    at [PATH]/node_modules/recursive-readdir/index.js:64:22
    at [PATH]/node_modules/recursive-readdir/index.js:64:22
@wadewegner
Copy link
Author

Note that @sindresorhus punted to you. sindresorhus/get-urls#15 (comment)

@KiranShakya
Copy link

@wadewegner is it still reproducible? I tried with the latest master and the problem is probably resolved.

@niftylettuce
Copy link
Collaborator

Please use https://github.com/niftylettuce/url-regex-safe as this package has a severe vulnerability (see #70).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants