Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure processing 2022-03-07T:: #515

Closed
kaie opened this issue Jun 22, 2022 · 4 comments
Closed

Failure processing 2022-03-07T:: #515

kaie opened this issue Jun 22, 2022 · 4 comments

Comments

@kaie
Copy link

kaie commented Jun 22, 2022

A calendar found in the wild contains date time values of the following format: 2022-03-07T::

While this is clearly a bad format, it seems the calendar code attempts to be lenient, so it might be good to attempt to handle this, too.

Originally reported at https://bugzilla.mozilla.org/show_bug.cgi?id=1754412

kaie added a commit to kaie/ical.js that referenced this issue Jun 22, 2022
@kaie
Copy link
Author

kaie commented Jun 22, 2022

pull request: #516

@twalling
Copy link

I was seeing this error this week when trying to parse this ICS file http://www.calendarlabs.com/ical-calendar/ics/76/US_Holidays.ics

It's different than the ones I've seen from google which include a VALUE=DATE string with each DTSTART and DTEND. Whenever I got to the point of trying to access those properties and the value was being wrapped in an ICAL.Time model I was seeing an error like you described above, 2021-01-01T:: in this case.

@edd189
Copy link

edd189 commented Jun 10, 2023

I was seeing this error this week when trying to parse this ICS file http://www.calendarlabs.com/ical-calendar/ics/76/US_Holidays.ics

It's different than the ones I've seen from google which include a VALUE=DATE string with each DTSTART and DTEND. Whenever I got to the point of trying to access those properties and the value was being wrapped in an ICAL.Time model I was seeing an error like you described above, 2021-01-01T:: in this case.

Reporting same issue here. Throwing an error when the DTSTART or DTEND does not contain a time component. This appears to be allowed by the ics standard: https://datatracker.ietf.org/doc/html/rfc5545#section-3.8.2

Value Type: The default value type is DATE-TIME. The value type can be set to a DATE value type. ("DATE-TIME" / "DATE")

@kewisch
Copy link
Owner

kewisch commented Apr 1, 2024

Let's continue in #620

@kewisch kewisch closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants