Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using unregistered Timezones should throw a warning #582

Open
CardiJey opened this issue May 7, 2023 · 1 comment
Open

Using unregistered Timezones should throw a warning #582

CardiJey opened this issue May 7, 2023 · 1 comment

Comments

@CardiJey
Copy link

CardiJey commented May 7, 2023

Hi,
I've been wondering for a long time why something goes wrong with the timezones when using Time.toJSDate().
Only now, I found out, that I did not register the timezone of the ical file beforehand. I think you can save a lot of people a lot of time if the function throws some kind of error when using an unregistered timezone, instead of just defaulting to UTC.

@kewisch
Copy link
Owner

kewisch commented Apr 1, 2024

This sounds reasonable, though we'll have to find out in which cases to throw and where. For anyone looking into this, keep in mind that the IANA timezones, such as Europe/Berlin, are valid even if not explicitly in a VTIMEZONE block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants