Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling numlock off doesn't turn it off in the OS #42

Open
edanaher opened this issue Feb 22, 2018 · 1 comment
Open

Toggling numlock off doesn't turn it off in the OS #42

edanaher opened this issue Feb 22, 2018 · 1 comment
Assignees
Labels

Comments

@edanaher
Copy link

edanaher commented Feb 22, 2018

As @warewolf noted on #29, with the default firmware, turning Numlock on works as expected, but turning Numlock off turns the LEDs off and reverts back to the default layer, but leaves the Numlock state still set in the OS.

This means that any other keyboards attached will leave the Capslock LED on, and any applications that check the state of Numlock will be confused (I'm guessing there are extremely few of these - @warewolf and I both noticed this in FVWM.)

edit: Filing this as a fresh bug, since the original bug in #29 was numlock not working, not numlock not turning itself off properly.

edanaher added a commit to edanaher/Kaleidoscope-NumPad that referenced this issue Feb 22, 2018
This avoids the OS being stuck with Numlock on, which leaves the LED on
if other keyboard are attached, and breaks FVWM.

See keyboardio/Model01-Firmware#42
@edanaher
Copy link
Author

I submitted a PR to the relevant plugin. However, this still leaves a minor annoyance: the Model 01 "owns" numlock, in that if it's on, no other attached keyboard can turn it off. I suspect multiple keyboard use is pretty rare (except when getting started with the Model 01), so it's not a huge issue, but it does seem kind of rude.

(This follows from the way the NumPad plugin works - if the numpad is on, it forces the LED on. And this happens in the hook, which I gather is run on every "tick"; I'm still figuring out Kaleidoscope...)

@algernon algernon added the bug label Feb 26, 2018
@algernon algernon self-assigned this Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants