Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var/main.yml includes python dependencies #30

Open
koh-osug opened this issue Nov 23, 2023 · 4 comments
Open

var/main.yml includes python dependencies #30

koh-osug opened this issue Nov 23, 2023 · 4 comments
Assignees

Comments

@koh-osug
Copy link

koh-osug commented Nov 23, 2023

I would assume that the python dependencies are not needed for the Rust agent anymore, but I still see them listed. Are they really still needed?

# requirements
dependencies:
  ['autoconf',
   'autoconf-archive',
   'automake',
   'clang-devel',
   'dbus-devel',
   'gcc',
   'git',
   'glib2-devel',
   'keylime',
   'libcurl-devel',
   'libgcrypt-devel',
   'libstdc++-devel',
   'libtool',
   'libffi-devel',
   'pkg-config',
   'python3-cryptography',
   'python3-devel',
   'python3-pyyaml',
   'python3-yaml',
   'python3-simplejson',
   'python3-sqlalchemy',
   'python3-alembic',
   'redhat-rpm-config',
   'tpm2-tools',
   'tpm2-tss',
   'tpm2-tss-devel',
   'uriparser-devel',
   'efivar-devel',
   'cargo',
   'openssl-devel',
   'zeromq-devel',
   'libarchive-devel']

# section for vars
shell_profiles:
  - .bash_profile~¨
  - ~~~
@THS-on
Copy link
Member

THS-on commented Nov 25, 2023

@mpeters are we also installing the server side? If not the python ant tpm2-tools dependencies can be indeed removed

@koh-osug
Copy link
Author

koh-osug commented Nov 26, 2023

What I can say is it works without them just fine. For an Ubuntu installation these dependendies are suffcient:

dependencies:
  ['libarchive-dev',
   'libclang-dev',
   'libssl-dev',
   'libtss2-dev',
   'pkg-config',
   'coreutils',
   'libarchive13',
   'libssl3',
   'libtss2-esys-3.0.2-0',
   'curl',
   'git',
   'make',
   'cargo']

BTW. Is it of interest not only to support Fedora? I have added an OS condition to load OS specific dependencies which would allow to support other package managers.

@mpeters
Copy link
Member

mpeters commented Nov 27, 2023

@mpeters are we also installing the server side? If not the python ant tpm2-tools dependencies can be indeed removed

We shouldn't be mixing the installs, so it should be safe to remove. Just throwing this out to @ansasaki just in case there's some packaging wrinkle I'm not thinking about.

@ansasaki
Copy link

@mpeters are we also installing the server side? If not the python ant tpm2-tools dependencies can be indeed removed

We shouldn't be mixing the installs, so it should be safe to remove. Just throwing this out to @ansasaki just in case there's some packaging wrinkle I'm not thinking about.

Looking into the rules, it is compiling and installing the keylime agent from the source, so the required dependencies are the build requirements for the agent. There are no dependencies coming from the packaging.

That said, I think the python dependencies can be dropped.

BTW, this should be updated, it is using very old Fedora releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants