Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Weight isnt supported in the initial branding-tokens file #82

Open
fleven-kds opened this issue Jul 24, 2024 · 0 comments
Open

Font Weight isnt supported in the initial branding-tokens file #82

fleven-kds opened this issue Jul 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@fleven-kds
Copy link
Collaborator

The branding-token.json file only allows for the specific font weights:

"font-weight": {
   "light": 300,
   "regular": 400,
   "semi-bold": 600,
   "bold": 700
},

In ds-agency the font weight medium is added and used in for example topics.
This means upon a branding-init the fonts weight can never cover the entire span of the weights used in ds-agency, leading to topics having a non supported font weight thus simply being set to 400.

This issue might resolve itself once we refactored the branding token.

@fleven-kds fleven-kds added the bug Something isn't working label Jul 24, 2024
@fleven-kds fleven-kds transferred this issue from kickstartDS/ds-agency Nov 27, 2024
@julrich julrich transferred this issue from kickstartDS/ds-agency-premium Dec 5, 2024
@julrich julrich moved this to Backlog in CMS Starter Storyblok Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant