Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Lätkäzombit into its own project #123

Open
evktalo opened this issue Sep 22, 2019 · 2 comments
Open

Separate Lätkäzombit into its own project #123

evktalo opened this issue Sep 22, 2019 · 2 comments
Milestone
0.5

Comments

@evktalo
Copy link
Member

evktalo commented Sep 22, 2019

Blocked by at least #29, #120, #119, #114, #113, #83
@evktalo
Copy link
Member Author

evktalo commented Mar 11, 2021

#29 is not technically necessary. The adventure engine itself doesn't need to come with an adventure, and LZ can be separated before a more template-ish example adventure exists.

@evktalo evktalo added this to the 0.5 milestone Mar 11, 2021
evktalo added a commit that referenced this issue Mar 11, 2021
@evktalo
Move game data files to data directory (#149)
795f632 
A step towards #123 

As a side effect, throw an exception on 404 when loading json files.

Probably breaks KGED compatibility.
@evktalo
Copy link
Member Author

evktalo commented Oct 6, 2024 •
edited
Loading

At the moment, it's difficult to test the engine without a game, and it's a bit cumbersome to test if LZ is separated. Maybe that's something to live with. But the testing I'm talking about is manual at the moment anyway, and I suppose it's not a huge step to run both the projects manually locally.

If we have automated e2e tests though, I wonder if I'd rather generate "games" with a fixture for the tests than have a manually updated example game. "Why not both" of course..

Anyway, thinking about this certainly highlights the lack of test automation coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@evktalo