Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: checks fail for me on changes after initial PR submission. #254

Closed
dan-da opened this issue Nov 28, 2022 · 2 comments
Closed

ci: checks fail for me on changes after initial PR submission. #254

dan-da opened this issue Nov 28, 2022 · 2 comments

Comments

@dan-da
Copy link

dan-da commented Nov 28, 2022

See this comment and this commit, which fixes the first issue for me.

The subsequent gh-pages issue seems related to this.

Strangely, there is no [x] on the PR or the commits that fail. The only way I get any notice and can find the build log is by email.

@racs4
Copy link
Contributor

racs4 commented Dec 1, 2022

The subsequent gh-pages issue seems related to r-lib/pkgdown#1223.
Strangely, there is no [x] on the PR or the commits that fail. The only way I get any notice and can find the build log is by email.

This should be no problem as I removed the bench workflow in ab32905, since it was not being used anymore.

I also added a skip checking for the normal CI workflow (clippy and test); This will prevent workflows from being duplicated in pull requests, and will cancel outdated workflows if you push new commits on the same branch.

About some workflows not being executed when a push is made, I think this is related to forced push only, and I don't know how to fix it.

@dan-da
Copy link
Author

dan-da commented Dec 1, 2022

thx, I will reopen if I see further weirdness.

@dan-da dan-da closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants