From 6aa0d96483cc2d1f2ef2254718f6d6b2df9485f5 Mon Sep 17 00:00:00 2001 From: "Florian (Feuermagier)" Date: Thu, 17 Oct 2024 13:46:31 +0200 Subject: [PATCH] fix wrong test results for zero-point mandatory tests (fixes #60) --- .../sdq/intelligrade/extensions/guis/TestCasePanel.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/main/java/edu/kit/kastel/sdq/intelligrade/extensions/guis/TestCasePanel.java b/src/main/java/edu/kit/kastel/sdq/intelligrade/extensions/guis/TestCasePanel.java index 58d90b1..5b7e3c7 100644 --- a/src/main/java/edu/kit/kastel/sdq/intelligrade/extensions/guis/TestCasePanel.java +++ b/src/main/java/edu/kit/kastel/sdq/intelligrade/extensions/guis/TestCasePanel.java @@ -28,9 +28,11 @@ public TestCasePanel() { for (var result : testResults) { String tooltip = result.getDetailText().orElse("No details available"); - var icon = result.getPoints() != 0.0 - ? AllIcons.RunConfigurations.TestPassed - : AllIcons.RunConfigurations.TestFailed; + // isPositive() is true if the test passed, regardless of its points + // (which may be zero for mandatory tests) + var icon = result.getPositive() + .map(p -> p ? AllIcons.RunConfigurations.TestPassed : AllIcons.RunConfigurations.TestFailed) + .orElse(AllIcons.RunConfigurations.TestUnknown); var iconLabel = new JBLabel(icon); iconLabel.setToolTipText(tooltip); this.content.add(iconLabel);