Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multivolume Work: page view: three "undefined" in navigation #12

Open
BFallert opened this issue Jun 25, 2019 · 2 comments
Open

Multivolume Work: page view: three "undefined" in navigation #12

BFallert opened this issue Jun 25, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@BFallert
Copy link
Collaborator

When i open a Multivolume Work in page view i see tree "undefined" in navigation:

<ul class="tx-dlf-navigation">
....
<li class="tx-dlf-navigation-edit">undefined</li>
<li class="tx-dlf-navigation-editRemove" style="padding-left: 4px;">undefined</li>
<li class="tx-dlf-navigation-magnifier" style="padding-left: 4px;">undefined</li>

You can see this in the Demo-Installation
Das Steinkohlenrevier von Lugau-Oelsnitz:
https://presentation-demo.kitodo.org/index.php?id=4&tx_dlf%5Bid%5D=797&tx_dlf%5Bpage%5D=1

image

For a volume or monograph, the following will be displayed instead
image

@chrizzor
Copy link
Collaborator

Fixed with commit:
f917938

@BFallert
Copy link
Collaborator Author

BFallert commented Jul 1, 2019

We don't use the DLF:Basket plugin!

So now i see at a Multivolume Work:
image

But i see now that i have to see this only if i use the DLF:Basket plugin.

When i open a 'normal' book i get a empty <div class="tx-dlf-navigation-edit">` and so i see there no button.

Perhaps you can check the merken-Button <button id="submitBasketForm" onclick="this.form.submit()">merken</button> so you can check if a id submitBasketForm exists.

if ($('.tx-dlf-navigation-edit').length) {
    $('ul.tx-dlf-navigation').append('<li class="tx-dlf-navigation-edit">' + $('.tx-dlf-navigation-edit').html() + '</li>');
} else {
    if ($('#submitBasketForm').length) {	
        $('ul.tx-dlf-navigation').append('<li class="tx-dlf-navigation-edit"><span></span></li>');
    }

}

...
(the same with the other two buttons)

Should i do a PR?

@BFallert BFallert reopened this Jul 1, 2019
@sebastian-meyer sebastian-meyer added the enhancement New feature or request label Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants