kiwix-build.py should detect early if a dependency (svn for example) is not available (and complain) #49
Labels
Comments
|
@mgautierfr I had the same "problem" with subversion. I agree with @anarcat that it should be just checked at the beginning an reported properly. @anarcat for ninja and meson, I agree with you that this is a bit annoying to have to install both of them manually. So far, we have do to so, as we need pretty recent version of them. AFAIK, next Debian stable will be OK. |
|
There is also a ticket to improve a bit the README #3. Will work on this. |
kelson42
changed the title
mgautierfr
added a commit
that referenced
this issue
Jun 12, 2017
…lding. Factorize a bit the code also. Fixes #49.
mgautierfr
added a commit
that referenced
this issue
Jun 12, 2017
…lding. Factorize a bit the code also. Fixes #49.
automactic
added a commit
that referenced
this issue
Jun 20, 2017
* Add an option to hide intermediate progress information. * Hide the progress information in TravisCI. With progress information shown, the android build logs are bigger than 4Mo and travisBuild fails. So we have to hide them in travis. * Move `_patch` method in `Source` class. The patch method is not specific to a `RealeaseDownload` source. * Add a `SvnSource`. This is needed to get source from svn. * Get ICU source from SVN instead of Release archive. ICU doesn't provide data sources in their release archives but directly pre-compiled data. As we need to compile ourselves our data to remove unwanted data, we need to get the sources directly from the SVN. * Patch ICU to remove unwanted data. We don't need all the ICU data and we need to reduce binaries' size (Especially for android where we have a limit of 50Mo per APK). By removing unwanted ICU data, we reduce a lot the data size and so the final binaries' size. There is also some "problems" to compile the `ja.txt` collfiles, the "resource compiler" crashes. As we don't need it, we also remove it. * Use ICU data as external archive on android platform. On android platform, we load the ICU data as external data, not embeded in the kiwix-lib. So we need to generate correctly the dat file and use it in kiwix-android. * Do not force specific arguments when compiling for win32. Those option should be set by build system, not by kiwix-build. Moreover, this impact other libraries (as icu) and generate pretty big library binaries. * Better argument parse for better help text. (And one clean line :) ) * Correctly declare dependencies of kiwix-build and projects we are building. Factorize a bit the code also. Fixes #49. * Set the android_abi variable in the meson_cross_file.txt Kiwix-lib need to know want is the android abi to copy the lib in the right directory.
|
I agree with this proposal. I had a similar issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
on a fresh new Debian stretch install, I followed the instructions of this readme and Kiwix failed to compile because SVN was missing. it should detect that and just install subversion through
apt-get install subversion.(similarly, why aren't meson and ninja installed that way? just
apt-get install mesonwas enough here...)The text was updated successfully, but these errors were encountered: