Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign source tarball #540

Open
kelson42 opened this issue Sep 4, 2022 · 10 comments · May be fixed by #802
Open

Sign source tarball #540

kelson42 opened this issue Sep 4, 2022 · 10 comments · May be fixed by #802

Comments

@kelson42
Copy link
Contributor

kelson42 commented Sep 4, 2022

Provide detached signature with zimlib and kiwix tarballs. Debian project now encourages upstream to provided signed tarballs so we can make sure nothing is tampered with tarball while we download
https://www.gnupg.org/gph/en/manual/x135.html

From https://sourceforge.net/p/kiwix/feature-requests/809/

@dilankavishka
Copy link

Can i work on this issue please? @kelson42

@dev-KartikSharma
Copy link

Hi @kelson42 , I noticed this issue was raised a year ago, and I wanted to check if it’s still available to work on. Is the assignment of this issue still open? I'd be happy to contribute if needed.

Thanks!

@kelson42
Copy link
Contributor Author

kelson42 commented Jan 1, 2025

@dev-KartikSharma Yes, how do you want to proceed?

@dev-KartikSharma
Copy link

to provide a detached signature for your tarballs using zimlib and kiwix can use GPG to generate and verify the signature of tarballs thats the idea i'm thinking of

@dev-KartikSharma
Copy link

Hi @kelson42,
I’ve made a few changes to builder.py to handle the GPG tarballs signature. I believe it’s ready for a PR, but I wanted to confirm if these changes align with the project's goals. Looking forward to your feedback before proceeding!
Thanks in advance!

@kelson42
Copy link
Contributor Author

kelson42 commented Jan 4, 2025

@dev-KartikSharma Please make PR so we can have a look please

@dev-KartikSharma
Copy link

I’ve submitted the PR please take a look when you get a chance. I’m waiting for your review or any suggestions for further changes.

@kelson42 kelson42 linked a pull request Jan 4, 2025 that will close this issue
@dev-KartikSharma
Copy link

dev-KartikSharma commented Jan 7, 2025

@kelson42 was I supposed to mention you for review in the Pull request??

@kelson42
Copy link
Contributor Author

kelson42 commented Jan 7, 2025

@dev-KartikSharma yes and no... but now this is clear that your PR is ready to review.

@dev-KartikSharma
Copy link

@kelson42 it's was the first ever pr so I had no idea about it😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants