From 56906d540a3ca573eb9e8545d440ae2547ffe4d6 Mon Sep 17 00:00:00 2001
From: Jaifroid <egk10@cam.ac.uk>
Date: Fri, 4 Nov 2022 08:31:39 +0000
Subject: [PATCH] Disable Firefox latest in cross-browser tests and disable
 end-to-end tests #894 (#895)

---
 .github/workflows/CI.yml      | 40 +++++++++++++++++------------------
 nightwatch.js                 |  5 +++--
 tests/karma.conf.saucelabs.js | 21 ++++++++++--------
 3 files changed, 35 insertions(+), 31 deletions(-)

diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
index 0a1f4794d..4e6af25af 100644
--- a/.github/workflows/CI.yml
+++ b/.github/workflows/CI.yml
@@ -90,27 +90,27 @@ jobs:
 
 
       # Start a SauceLabs tunnel for Nightwatch (Karma does this automatically)
-      - name: Start tunnel for End-to-end tests
-        uses: saucelabs/sauce-connect-action@v1.1.2
-        with:
-          username: ${{ secrets.SAUCE_USERNAME }}
-          accessKey: ${{ secrets.SAUCE_ACCESS_KEY }}
+      # - name: Start tunnel for End-to-end tests
+      #   uses: saucelabs/sauce-connect-action@v1.1.2
+      #   with:
+      #     username: ${{ secrets.SAUCE_USERNAME }}
+      #     accessKey: ${{ secrets.SAUCE_ACCESS_KEY }}
 
-      - name: End-to-end tests (Cross-browser)
-        env:
-          SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }}
-          SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}
-        run: |
-          ./node_modules/.bin/http-server . &
-          sleep 2
-          curl "http://localhost:8080" | head
-          # The free account on Sauce does not allow more than 5 concurrent sessions (including the main one)
-          # So we separate the recent and old browsers in order to respect this limit.
-          # REMINDER: Keep this list in sync with the Unit tests, in tests/karma.conf.saucelabs.js
-          ./node_modules/.bin/nightwatch -c nightwatch.js --env firefox,chrome,edge
-          ./node_modules/.bin/nightwatch -c nightwatch.js --env edge40,edge44
-          ./node_modules/.bin/nightwatch -c nightwatch.js --env firefox45,chrome58,ie11
-          pkill node || echo "Node process not running (anymore)"
+      # - name: End-to-end tests (Cross-browser)
+      #   env:
+      #     SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }}
+      #     SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}
+      #   run: |
+      #     ./node_modules/.bin/http-server . &
+      #     sleep 2
+      #     curl "http://localhost:8080" | head
+      #     # The free account on Sauce does not allow more than 5 concurrent sessions (including the main one)
+      #     # So we separate the recent and old browsers in order to respect this limit.
+      #     # REMINDER: Keep this list in sync with the Unit tests, in tests/karma.conf.saucelabs.js
+      #     ./node_modules/.bin/nightwatch -c nightwatch.js --env chrome,edge
+      #     ./node_modules/.bin/nightwatch -c nightwatch.js --env edge40,edge44
+      #     ./node_modules/.bin/nightwatch -c nightwatch.js --env firefox52,chrome58
+      #     pkill node || echo "Node process not running (anymore)"
 
   # Tests the list of offline files in the Service Worker and compares it to the contents of the www directory
   test-offline-files:
diff --git a/nightwatch.js b/nightwatch.js
index 6c14a1b2f..56c1628b4 100644
--- a/nightwatch.js
+++ b/nightwatch.js
@@ -46,10 +46,10 @@ module.exports = {
         "waitForConditionTimeout": 600
       }
     },
-    "firefox45" : {
+    "firefox52" : {
       "desiredCapabilities": {
         "browserName": "firefox",
-        "version": "45.0",
+        "version": "52.0",
         "javascriptEnabled": true,
         "acceptSslCerts": true,
         "build": build
@@ -58,6 +58,7 @@ module.exports = {
     "firefox" : {
       "desiredCapabilities": {
         "browserName": "firefox",
+        "version": "latest",
         "javascriptEnabled": true,
         "acceptSslCerts": true,
         "build": build
diff --git a/tests/karma.conf.saucelabs.js b/tests/karma.conf.saucelabs.js
index c4a73f212..6e25ce66c 100644
--- a/tests/karma.conf.saucelabs.js
+++ b/tests/karma.conf.saucelabs.js
@@ -10,41 +10,45 @@ module.exports = function (config) {
       accessKey: process.env.SAUCE_ACCESS_KEY
     },
     customLaunchers: {
-      firefox45: {
+      firefox52: {
         base: 'SauceLabs',
         browserName: 'firefox',
-        version: '45.0'
+        version: '52.0'
       },
       firefox: {
         base: 'SauceLabs',
         browserName: 'firefox',
+        version: 'latest'
       },
       chrome58: {
         base: 'SauceLabs',
         browserName: 'chrome',
-        version: '58.0',
+        version: '58.0'
       },
       chrome: {
         base: 'SauceLabs',
         browserName: 'chrome',
+        version: 'latest'
       },
       edge: {
         base: 'SauceLabs',
         browserName: 'MicrosoftEdge',
+        version: 'latest'
       },
       edge40: {
         base: 'SauceLabs',
         browserName: 'MicrosoftEdge',
-        version: '15.15063',
+        version: '15.15063'
       },
       edge44: {
         base: 'SauceLabs',
         browserName: 'MicrosoftEdge',
-        version: '18.17763',
+        version: '18.17763'
       },
       ie11: {
         base: 'SauceLabs',
         browserName: 'internet explorer',
+        version: 'latest'
       }
     },
     // The free account on Sauce does not allow more than 5 concurrent sessions
@@ -52,15 +56,14 @@ module.exports = function (config) {
 
     // REMINDER: Keep this list in sync with the UI tests, in .github/workflows/CI.yml.
     browsers: [
-      'firefox',
+      // 'firefox', // Disable latest Firefox due to #894
       'chrome',
       'edge',
       'edge40',
       'edge44',
-      'firefox45',
+      'firefox52',
       'chrome58'
-      // Skip unit tests in Internet Explorer due to Promise undefined
-      // 'ie11'
+      // 'ie11' // Disable IE11 due to Promise error
     ],
     frameworks: ['qunit'],
     client: {