Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the ServiceWorker fails to register, we should automatically fallback to jQuery mode #405

Closed
mossroy opened this issue Aug 5, 2018 · 2 comments
Closed

If the ServiceWorker fails to register, we should automatically fallback to jQuery mode #405

mossroy opened this issue Aug 5, 2018 · 2 comments
Labels
enhancement
Milestone
v2.4

Comments

@mossroy
Copy link
Contributor

mossroy commented Aug 5, 2018

We already do that if the ServiceWorker API is unavailable.
But when it's available and can not be registered (for example when running from file://), we currently do not do the fallback automatically.
@mossroy mossroy added this to the v2.4 milestone Aug 5, 2018
@mossroy
Copy link
Contributor Author

mossroy commented Aug 5, 2018

I think it's needed for #196

@mossroy mossroy modified the milestones: v2.4, v2.5 Sep 22, 2018
@mossroy
Copy link
Contributor Author

mossroy commented Sep 22, 2018

This can be easily reproduced by opening with Firefox the index.html file (through file:// protocol), and trying to switch to SW mode. I'm preparing a PR to fix that

mossroy added a commit that referenced this issue Sep 22, 2018
@mossroy
Automatically fallback to jQuery mode if the SW fails to register.
ff59a86 
Fixes #405
@mossroy mossroy mentioned this issue Sep 22, 2018
Merged
mossroy added a commit that referenced this issue Sep 22, 2018
@mossroy
Automatically fallback to jQuery mode if the SW fails to register.
922d19a 
Fixes #405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v2.4
Development

No branches or pull requests
1 participant
@mossroy